mirror of
https://github.com/mihonapp/mihon.git
synced 2026-10-23 17:09:49 -07:00
Redact some sensitive headers in logcat (#4156)
This commit is contained in:
+9
@@ -97,6 +97,15 @@ object SettingsAdvancedScreen : SearchableSettings {
|
||||
true
|
||||
},
|
||||
),
|
||||
Preference.PreferenceItem.SwitchPreference(
|
||||
preference = networkPreferences.redactSensitiveHeaders,
|
||||
title = stringResource(MR.strings.pref_redact_sensitive_headers),
|
||||
subtitle = stringResource(MR.strings.pref_redact_sensitive_headers_summary),
|
||||
onValueChanged = {
|
||||
context.toast(MR.strings.requires_app_restart)
|
||||
true
|
||||
},
|
||||
),
|
||||
Preference.PreferenceItem.TextPreference(
|
||||
title = stringResource(MR.strings.pref_debug_info),
|
||||
onClick = { navigator.push(DebugInfoScreen()) },
|
||||
|
||||
@@ -44,6 +44,10 @@ class NetworkHelper(
|
||||
if (preferences.verboseLogging.get()) {
|
||||
val httpLoggingInterceptor = HttpLoggingInterceptor().apply {
|
||||
level = HttpLoggingInterceptor.Level.HEADERS
|
||||
if (preferences.redactSensitiveHeaders.get()) {
|
||||
redactHeader("Authorization")
|
||||
redactHeader("Auth")
|
||||
}
|
||||
}
|
||||
builder.addNetworkInterceptor(httpLoggingInterceptor)
|
||||
}
|
||||
|
||||
@@ -14,6 +14,11 @@ class NetworkPreferences(
|
||||
@IsDebugBuild isDebugBuild: Boolean,
|
||||
) {
|
||||
|
||||
val redactSensitiveHeaders: Preference<Boolean> = preferenceStore.getBoolean(
|
||||
"redact_sensitive_headers",
|
||||
true,
|
||||
)
|
||||
|
||||
val verboseLogging: Preference<Boolean> = preferenceStore.getBoolean(
|
||||
"verbose_logging",
|
||||
isDebugBuild,
|
||||
|
||||
@@ -696,6 +696,8 @@
|
||||
<string name="pref_tablet_ui_mode">Tablet UI</string>
|
||||
<string name="pref_verbose_logging">Verbose logging</string>
|
||||
<string name="pref_verbose_logging_summary">Print verbose logs to system log (reduces app performance)</string>
|
||||
<string name="pref_redact_sensitive_headers">Redact sensitive headers</string>
|
||||
<string name="pref_redact_sensitive_headers_summary">Redacts certain sensitive values in the logs. Keep enabled for your security when sharing logs with other people.</string>
|
||||
<string name="pref_debug_info">Debug info</string>
|
||||
<string name="pref_update_library_manga_titles">Update library manga titles to match source</string>
|
||||
<string name="pref_update_library_manga_titles_summary">Warning: if a manga is renamed, it will be removed from the download queue (if present).</string>
|
||||
|
||||
Reference in New Issue
Block a user